rahilansari

Dear Jens

Excuse me for my late come back, I was stuck in other works last days.
I read the SCL code you send to arrange the pumps and assign the priority numbers from lowest to highest based on the Runtime calculation, I changed my block accordingly and used the WorkingTimes[0..7] array of Struct to start and stop my pumps but getting some errors specially in the
"CASE" statement below the the code and please advice if something wrong.

I made an improved? version of Jens_app's version.
Tried to reduce the working code and cycle time.
Added an function that selects 4 pumps based on requested no of pumps.

This code has NOT been tested!
I'm sure that it could be programmed more clever but SCL is not my cup of tea!

FUNCTION_BLOCK "PumpWorkingTime"
{ S7_Optimized_Access := 'FALSE' }
VERSION : 0.2
   VAR_INPUT
      No_of_pumps : Int;   // How many pumps to be run
      Pump1 : Bool;   // Response if pump is running
      Pump2 : Bool := false;   // Response if pump is running
      Pump3 : Bool := false;   // Response if pump is running
      Pump4 : Bool := false;   // Response if pump is running
      M_Clockbit1s : Bool;   // Clockbit 1hz
   END_VAR

   VAR_OUTPUT
      Pump1_On : Bool;   // Run pump1
      Pump2_On : Bool;   // Run pump2
      Pump3_On : Bool;   // Run pump3
      Pump4_On : Bool;   // Run pump4
   END_VAR

   VAR
      WorkingTimes : Array[1..4] of UDInt;   // Workingtimes of each pump
      Priority : Array[1..4] of Struct
         "time" : UDInt;
         pump_no : Int;
      END_STRUCT;
      Pump_Out : Array[1..4] of Bool;
      Trig_Memory : Bool;
   END_VAR

   VAR_TEMP
      PumpActiveSignal : Array[1..4] of Bool;   // Active signal from pumps
      index : Int;
      index2 : Int;
      temp : UDInt;
      Index_no : Int;
      actual_pumps : Int;
   END_VAR

BEGIN
 IF #M_Clockbit1s = true AND #Trig_Memory = false THEN // Execute this on a positive edge of the memoryclockbit
     #PumpActiveSignal[1] := #Pump1;
     #PumpActiveSignal[2] := #Pump2;
     #PumpActiveSignal[3] := #Pump3;
     #PumpActiveSignal[4] := #Pump4;
    
     FOR #index := 1 TO 4 DO // Increase working time count if the pump is active (up to 136 years with Unsigned Double INTeger)
         IF #PumpActiveSignal[#index] = true THEN
             #WorkingTimes[#index] := #WorkingTimes[#index] + 1; // Increase the working time
             #Priority[#index]."time" := #WorkingTimes[#index]; // Move working times to list that needs to be ordered
             #Priority[#index].pump_no := #index;
         END_IF;
     END_FOR;
    
     FOR #index := 1 TO 3 DO // Order working times, lowest to highest     
         FOR #index2 := #index + 1 TO 3 DO
             IF #Priority[#index]."time" > #Priority[#index2]."time" THEN
                 #temp := #Priority[#index]."time";
                 #Index_no := #Priority[#index].pump_no;
                 #Priority[#index]."time" := #Priority[#index2]."time";
                 #Priority[#index].pump_no := #Priority[#index2].pump_no;
                 #Priority[#index2]."time" := #temp;
                 #Priority[#index].pump_no := #Index_no;
             END_IF;
         END_FOR;
     END_FOR;
 END_IF;
 
 #actual_pumps := 0;
 FOR #index := 1 TO 4 DO
     IF #Pump_Out[#index] = true THEN
         #actual_pumps := #actual_pumps + 1;
     END_IF;
 END_FOR;
 
 IF #No_of_pumps > #actual_pumps THEN
     FOR #index := 1 TO 4 DO // Turn on lowest runtime first
         IF #PumpActiveSignal[#Priority[#index].pump_no] = FALSE THEN
             #Pump_Out[#Priority[#index].pump_no] := TRUE;
             EXIT;
         END_IF;
     END_FOR;
    
 ELSIF #No_of_pumps < #actual_pumps THEN
     #index := 4;
     WHILE #index < 1 DO // Turn off highest runtime first
         IF #PumpActiveSignal[#Priority[#index].pump_no] = TRUE THEN
             #Pump_Out[#Priority[#index].pump_no] := FALSE;
             EXIT;
         END_IF;
         #index := #index - 1;
     END_WHILE;
 END_IF;
 
 #Pump1_On := #Pump_Out[1];
 #Pump2_On := #Pump_Out[2];
 #Pump3_On := #Pump_Out[3];
 #Pump4_On := #Pump_Out[4];
 
 #Trig_Memory := #M_Clockbit1s;
END_FUNCTION_BLOCK

HEY BRO 

 CAN YOU GIVE ME THIS CODE WITH LADDER LOGIC PLEAZE I NEED IT