Jens_app

Hi visnia,

Nice to see you so interested,this doesn't look too bad, on first sight I see some form of loop is missing in your program. If you have stored a value in the last location of your DB, you would want to start from the beginning. So something maybe if index reached 500 start from 0.
Also now for example if your index is 0 you will store IN1 in DB10.DW0 and IN2 in DB10.DW4, but if your index is lesser then DBsize you will increase your index by 4. So you will store IN1 in DB10.DW4 and IN2 in DB10.DW8.
You see the problem here? Instead of storing in the next location you will overwrite your previous IN2 value with your actual IN1 value. Also a word will occupy 2 bytes, so if you want IN1 and IN2 to be behind eachother in your DB,
you would want to write DB10.DW[index] := in1 and DB10.DW[index+2]. So you would rather write something like this: DB10.DW[index] := in1; DB10.DW[index+2] and you'd want your index to increase with 4. So first store of in1 will be in DB10.DW0 (DB10.DW2 for in2) and second will be in DB10.DW4 for in1, DB10.DW6 for in2,... and so on)
Also Index would rather be defined INOUT, since you are writing and reading from it.

First of all thanks for clearing topic so deeply. Im not sure if i need some loop if my FB block will be called every OB32 call - that's will be a loop. First thing is i need to move 0 to the shared memory one time when i started logging, and i'm aware of that.

Conditional statement for continuous logging isn't bad idea tho.

Thanks for pointing me, that word is 2 bytes you did save some of my time. The same thing with increment indexes. It's obvious for me now. INOUT index - right. I'm soembarrassed by my stupidity :P

Jens_app

Now with that being corrected (hope it all makes sense, because it's obvious in my head but that doesn't make it understandable now I wrote it :p)

Sure thing, i'll test it today, we'll see what doesn't work. :)

Jens_app

I got a few pointers for you:
-Using arrays, one to store IN1, the other to store IN2 (Array[0..249] of WORD) might make your program "cleaner", you could also indirect address components in your array that way (example: "DBname".Value[i]) making your program more obvious and easy to follow for other users
-Using array of structures (array[0..249] of struct), struct containing stored in1 and in2 value
-Using user defined types (UDT), a bit identical as second suggestion, use array of UDT
-Time intervals for cyclic interrupt OBs can be configured inside the hardware properties of your CPU, too low time intervals might cause system failures, requesting a second execution of your interrupt OB before the first one is executed.

That's what I can come up with now, I hope it's a bit helpful

Kind regards,
Jens

Hi Visnia,

visnia

you will be my friend after a few more posts :P

visnia

Im not sure if i need some loop if my FB block will be called every OB32 call

visnia

Thanks for pointing me, that word is 2 bytes :) you did save some of my time. The same thing with increment indexes. It's obvious for me now. INOUT index - right. I'm so embarrassed by my stupidity :)

visnia

I'm not sure about Arrays

visnia

If isn't TIA PORTAL will report some error, or any error block will be called?

Kind regards,
Jens