Script C has stopped working in WinCC

Dear all,

I wrote some simple 'C code' in WinCC that read the lines of a defined text file. This code is trigged by a timer 2s. I started this code in WinCC Runtime normally. But it ran a period time, it has stucked the error "Script has stopped working". 

Please help me to check the attach code file that something is wrong or incorrect. 

Thank you.

Best regard,

Maybe you can provide an example of your file you want to process, I believe this can be programmed much easier.

But some points:

- check return value of fgets on not NULL

- strncpy does not null terminate the string, if the maximum number of chars is exceeded (limited).

- What if line is longer that 49 chars?

I haven't found it in the Siemens documentation, if variables on the stack are initialized. In any other environments, you have to initialize it for yourself, e.g. t[0] = '\0', y[0] = '\0' and so on.

And just some style comments: Use st1 as parameter for atof instead of reading the just written value again with GetTagChar. Use if/else instead of the several ifs, if first if is true, there's no need for other checks (just for performance), or use switch/case with the values you check, and the default section for your (value > 38) || (value < 33) range.

Murof

Hello minh.nq

I think you also have to allocate memory for your Char Pointer.

 From the code he has shown here, there's no need to allocate memory on the heap using SysMalloc. I believe using all the fixed values/offsets without any checks of the format of the read file result sometimes in an error, e.g. when the lines are too short at some specific points.

Dear experts,

Thank your for your advice. I found the cause for this. Sometime my c code is interrupted by reading the file that is null. I did the if..else for this to fixing the problem.

Thank you so much.